Join the Mozilla’s Test Days event from Dec 2–8 to test the new Firefox address bar on Firefox Beta 134 and get a chance to win Mozilla swag vouchers! 🎁

Avatar for Username

Kërkoni te Asistenca

Shmangni karremëzime gjoja asistence. S’do t’ju kërkojmë kurrë të bëni një thirrje apo të dërgoni tekst te një numër telefoni, apo të na jepni të dhëna personale. Ju lutemi, raportoni veprimtari të dyshimtë duke përdorur mundësinë “Raportoni Abuzim”.

Mësoni Më Tepër

Kjo rrjedhë është arkivuar. Ju lutemi, bëni një pyetje të re, nëse keni nevojë për ndihmë.

why JS_AddValueRoot() leads to "losing efficacy" of GC

  • 2 përgjigje
  • 1 e ka hasur këtë problem
  • 2 parje
  • Përgjigjja më e re nga blueconch.hg

blueconch.hg
blueconch.hg
more options

Here's my js code: 

     window.onload = function () {
       ...
       CarObject.addCallback("StringEvent", function(arg1, arg2){
         alert(arg2);
       });
       ...
     }

CarObject is a js variable, it maps to a C++ object internally, here I add a callback to the CarObject. as you see, the callback function is not a global function, so the callback function will be freed by GC. We use JS_AddValueRoot() which will add the callback function to GC's root set, this means the callback function(JSFunction *) will be protected from GC. but I found that it caught GC won't work, many object will be leaked when firefox exit.

Here's my js code: window.onload = function () { ... CarObject.addCallback("StringEvent", function(arg1, arg2){ alert(arg2); }); ... } CarObject is a js variable, it maps to a C++ object internally, here I add a callback to the CarObject. as you see, the callback function is not a global function, so the callback function will be freed by GC. We use JS_AddValueRoot() which will add the callback function to GC's root set, this means the callback function(JSFunction *) will be protected from GC. but I found that it caught GC won't work, many object will be leaked when firefox exit.

Krejt Përgjigjet (2)

philipp
philipp
  • Moderator
more options

hello blueconch.hg, could you file a bug report for that issue at bugzilla.mozilla.org there it will get the attention of developers quicker! thank you...

blueconch.hg
blueconch.hg I zoti i pyetjes
more options

thanks philipp, I'm using source code of fennec21.0, I'm not sure whether it will occur on the lasted version. The problem(GC losing effective, there will be many leads when fennec exit.) may not be caught by JS_AddValueRoot(), maybe it's our code's problem. But I will try your suggestion, put it to https://bugzilla.mozilla.org/